While national housing affordability could return to 2018 levels, buyers in New York City and Long Island may face another decade of high costs as home prices continue to outpace incomes.